mojo/converters/ime/ime_type_converters.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/converters/ime/ime_type_converters.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/converters/blink/blink_input_events_type_converters.cc ('k') | mojo/converters/input_events/input_events_type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/converters/ime/ime_type_converters.cc

diff --git a/mojo/converters/ime/ime_type_converters.cc b/mojo/converters/ime/ime_type_converters.cc

index 55a575766e713ad4374a873d58a50e9f45763f3e..6d95937ef7d5780b1ec4c528730730331ed06149 100644

--- a/mojo/converters/ime/ime_type_converters.cc

+++ b/mojo/converters/ime/ime_type_converters.cc

@@ -11,7 +11,7 @@

namespace mojo {

#define TEXT_INPUT_TYPE_ASSERT(NAME) \

- static_assert(static_cast<int32_t>(TEXT_INPUT_TYPE_##NAME) == \

+ static_assert(static_cast<int32_t>(TextInputType::NAME) == \

static_cast<int32_t>(ui::TEXT_INPUT_TYPE_##NAME), \

"TEXT_INPUT_TYPE must match")

TEXT_INPUT_TYPE_ASSERT(NONE);

@@ -31,7 +31,7 @@ TEXT_INPUT_TYPE_ASSERT(WEEK);

TEXT_INPUT_TYPE_ASSERT(TEXT_AREA);

#define TEXT_INPUT_FLAG_ASSERT(NAME) \

- static_assert(static_cast<int32_t>(TEXT_INPUT_FLAG_##NAME) == \

+ static_assert(static_cast<int32_t>(TextInputFlag::NAME) == \

static_cast<int32_t>(ui::TEXT_INPUT_FLAG_##NAME), \

"TEXT_INPUT_FLAG must match")

TEXT_INPUT_FLAG_ASSERT(NONE);