device/devices_app/usb/public/interfaces/device.mojom - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/devices_app/usb/public/interfaces/device.mojom

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/devices_app/usb/public/interfaces/device.mojom

diff --git a/device/devices_app/usb/public/interfaces/device.mojom b/device/devices_app/usb/public/interfaces/device.mojom

index 5382ce37e90d0185cb48fba2a5170f3c3e1fabe2..438aed14f922ad68a73b5ee09699bd89185d623d 100644

--- a/device/devices_app/usb/public/interfaces/device.mojom

+++ b/device/devices_app/usb/public/interfaces/device.mojom

@@ -13,8 +13,8 @@ enum OpenDeviceError {

};

enum TransferDirection {

- IN,

- OUT,

+ INBOUND,

+ OUTBOUND,

};

enum ControlTransferType {

@@ -113,7 +113,7 @@ enum TransferStatus {

COMPLETED,

// The transfer failed due to a non-specific error.

- ERROR,

+ TRANSFER_ERROR,

// The transfer was not allowed.

PERMISSION_DENIED,

« no previous file with comments | « device/devices_app/usb/device_impl_unittest.cc ('k') | device/devices_app/usb/type_converters.cc » ('j') | no next file with comments »