content/public/common/mojo_geoposition.mojom - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/mojo_geoposition.mojom

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_type_converters.cc ('k') | content/renderer/background_sync/background_sync_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/mojo_geoposition.mojom

diff --git a/content/public/common/mojo_geoposition.mojom b/content/public/common/mojo_geoposition.mojom

index 852f2a9c44bb6bf464eed9df249702a4564ab9bf..b88ffc22361df5fca1883ef433dd6eec6abe072c 100644

--- a/content/public/common/mojo_geoposition.mojom

+++ b/content/public/common/mojo_geoposition.mojom

@@ -14,11 +14,11 @@ struct MojoGeoposition {

// These values follow the W3C geolocation specification and can be returned

// to JavaScript without the need for a conversion.

enum ErrorCode {

- ERROR_CODE_NONE = 0, // Chrome addition.

- ERROR_CODE_PERMISSION_DENIED = 1,

- ERROR_CODE_POSITION_UNAVAILABLE = 2,

- ERROR_CODE_TIMEOUT = 3,

- ERROR_CODE_LAST = ERROR_CODE_TIMEOUT

+ NONE = 0, // Chrome addition.

+ PERMISSION_DENIED = 1,

+ POSITION_UNAVAILABLE = 2,

+ TIMEOUT = 3,

+ LAST = TIMEOUT

};

// Whether this geoposition is valid.