content/child/navigator_connect/service_port_dispatcher_impl.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/navigator_connect/service_port_dispatcher_impl.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/background_sync/background_sync_type_converters_unittest.cc ('k') | content/child/navigator_connect/service_port_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/navigator_connect/service_port_dispatcher_impl.cc

diff --git a/content/child/navigator_connect/service_port_dispatcher_impl.cc b/content/child/navigator_connect/service_port_dispatcher_impl.cc

index bc002a99c340f1ad0f988725211cf28b4fa1dd9e..8a63fd2785bcdc713279fbb1147d53d294c75f50 100644

--- a/content/child/navigator_connect/service_port_dispatcher_impl.cc

+++ b/content/child/navigator_connect/service_port_dispatcher_impl.cc

@@ -25,13 +25,13 @@ class WebConnectCallbacksImpl

~WebConnectCallbacksImpl() override {}

void onSuccess(const blink::WebServicePort& port) override {

- callback_.Run(SERVICE_PORT_CONNECT_RESULT_ACCEPT,

+ callback_.Run(ServicePortConnectResult::ACCEPT,

mojo::String::From<base::string16>(port.name),

mojo::String::From<base::string16>(port.data));

}

void onError() override {

- callback_.Run(SERVICE_PORT_CONNECT_RESULT_REJECT, mojo::String(""),

+ callback_.Run(ServicePortConnectResult::REJECT, mojo::String(""),

mojo::String(""));

}

@@ -67,7 +67,7 @@ void ServicePortDispatcherImpl::Connect(const mojo::String& target_url,

int32_t port_id,

const ConnectCallback& callback) {

if (!proxy_) {

- callback.Run(SERVICE_PORT_CONNECT_RESULT_REJECT, mojo::String(""),

+ callback.Run(ServicePortConnectResult::REJECT, mojo::String(""),

mojo::String(""));

return;

}