content/browser/push_messaging/push_messaging_message_filter.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/presentation/presentation_type_converters_unittest.cc ('k') | content/child/background_sync/background_sync_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_message_filter.cc

diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc

index 41668e37382e2596a048dde7836e7d8cb6b70b54..1efbc684917feeac4fb2e1522b24f3ea6dbcba6c 100644

--- a/content/browser/push_messaging/push_messaging_message_filter.cc

+++ b/content/browser/push_messaging/push_messaging_message_filter.cc

@@ -457,7 +457,7 @@ void PushMessagingMessageFilter::Core::DidRequestPermissionInIncognito(

PermissionStatus status) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Notification permission should always be denied in incognito.

- DCHECK_EQ(PERMISSION_STATUS_DENIED, status);

+ DCHECK_EQ(PermissionStatus::DENIED, status);

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE,

base::Bind(&PushMessagingMessageFilter::SendSubscriptionError, io_parent_,