content/browser/navigator_connect/navigator_connect_context_impl.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/navigator_connect/navigator_connect_context_impl.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/cdm/browser_cdm_manager.cc ('k') | content/browser/navigator_connect/service_port_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/navigator_connect/navigator_connect_context_impl.cc

diff --git a/content/browser/navigator_connect/navigator_connect_context_impl.cc b/content/browser/navigator_connect/navigator_connect_context_impl.cc

index f571b9fe5fd2037eadec5bac874d0bad33c7e34d..02459122ce822a21321b1efe4bcf6527501fa89e 100644

--- a/content/browser/navigator_connect/navigator_connect_context_impl.cc

+++ b/content/browser/navigator_connect/navigator_connect_context_impl.cc

@@ -226,7 +226,7 @@ void NavigatorConnectContextImpl::OnConnectResult(

if (!worker->FinishRequest(request_id))

return;

- if (result != SERVICE_PORT_CONNECT_RESULT_ACCEPT) {

+ if (result != ServicePortConnectResult::ACCEPT) {

OnConnectError(callback, client_port_id, service_port_id,

SERVICE_WORKER_ERROR_FAILED);

return;

« no previous file with comments | « content/browser/media/cdm/browser_cdm_manager.cc ('k') | content/browser/navigator_connect/service_port_service_impl.cc » ('j') | no next file with comments »