Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: content/browser/background_sync/background_sync_service_impl.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_service_impl.cc
diff --git a/content/browser/background_sync/background_sync_service_impl.cc b/content/browser/background_sync/background_sync_service_impl.cc
index ffab6abc995915522e9a114c970dd535b672e27b..f91def0aa4591bdc3a6b51e38de2094e2d241f83 100644
--- a/content/browser/background_sync/background_sync_service_impl.cc
+++ b/content/browser/background_sync/background_sync_service_impl.cc
@@ -54,40 +54,40 @@ SyncRegistrationPtr ToMojoRegistration(
"mojo and manager enums must match")
// TODO(iclelland): Move these tests somewhere else
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_ERROR_NONE,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncError::NONE,
BACKGROUND_SYNC_STATUS_OK);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_ERROR_STORAGE,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncError::STORAGE,
BACKGROUND_SYNC_STATUS_STORAGE_ERROR);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_ERROR_NOT_FOUND,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncError::NOT_FOUND,
BACKGROUND_SYNC_STATUS_NOT_FOUND);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_ERROR_NO_SERVICE_WORKER,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncError::NO_SERVICE_WORKER,
BACKGROUND_SYNC_STATUS_NO_SERVICE_WORKER);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_ERROR_NOT_ALLOWED,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncError::NOT_ALLOWED,
BACKGROUND_SYNC_STATUS_NOT_ALLOWED);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_ERROR_MAX,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncError::MAX,
BACKGROUND_SYNC_STATUS_NOT_ALLOWED);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_NETWORK_STATE_ANY,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncNetworkState::ANY,
SyncNetworkState::NETWORK_STATE_ANY);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_NETWORK_STATE_AVOID_CELLULAR,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncNetworkState::AVOID_CELLULAR,
SyncNetworkState::NETWORK_STATE_AVOID_CELLULAR);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_NETWORK_STATE_ONLINE,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncNetworkState::ONLINE,
SyncNetworkState::NETWORK_STATE_ONLINE);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_NETWORK_STATE_MAX,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncNetworkState::MAX,
SyncNetworkState::NETWORK_STATE_ONLINE);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_POWER_STATE_AUTO,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncPowerState::AUTO,
SyncPowerState::POWER_STATE_AUTO);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_POWER_STATE_AVOID_DRAINING,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncPowerState::AVOID_DRAINING,
SyncPowerState::POWER_STATE_AVOID_DRAINING);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_POWER_STATE_MAX,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncPowerState::MAX,
SyncPowerState::POWER_STATE_AVOID_DRAINING);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_PERIODICITY_PERIODIC,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncPeriodicity::PERIODIC,
SyncPeriodicity::SYNC_PERIODIC);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_PERIODICITY_ONE_SHOT,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncPeriodicity::ONE_SHOT,
SyncPeriodicity::SYNC_ONE_SHOT);
-COMPILE_ASSERT_MATCHING_ENUM(BACKGROUND_SYNC_PERIODICITY_MAX,
+COMPILE_ASSERT_MATCHING_ENUM(BackgroundSyncPeriodicity::MAX,
SyncPeriodicity::SYNC_ONE_SHOT);
BackgroundSyncServiceImpl::~BackgroundSyncServiceImpl() {
@@ -141,7 +141,7 @@ void BackgroundSyncServiceImpl::Unregister(
BackgroundSyncRegistrationHandle* registration =
active_handles_.Lookup(handle_id);
if (!registration) {
- callback.Run(BACKGROUND_SYNC_ERROR_NOT_ALLOWED);
+ callback.Run(BackgroundSyncError::NOT_ALLOWED);
return;
}
@@ -189,7 +189,7 @@ void BackgroundSyncServiceImpl::GetPermissionStatus(
// TODO(iclelland): Implement a real policy. This is a stub implementation.
// OneShot: crbug.com/482091
// Periodic: crbug.com/482093
- callback.Run(BACKGROUND_SYNC_ERROR_NONE, PERMISSION_STATUS_GRANTED);
+ callback.Run(BackgroundSyncError::NONE, PermissionStatus::GRANTED);
}
void BackgroundSyncServiceImpl::DuplicateRegistrationHandle(
@@ -206,7 +206,7 @@ void BackgroundSyncServiceImpl::DuplicateRegistrationHandle(
BackgroundSyncRegistrationHandle* handle_ptr = registration_handle.get();
if (!registration_handle) {
- callback.Run(BACKGROUND_SYNC_ERROR_NOT_FOUND,
+ callback.Run(BackgroundSyncError::NOT_FOUND,
SyncRegistrationPtr(content::SyncRegistration::New()));
return;
}
@@ -214,7 +214,7 @@ void BackgroundSyncServiceImpl::DuplicateRegistrationHandle(
active_handles_.AddWithID(registration_handle.release(),
handle_ptr->handle_id());
SyncRegistrationPtr mojoResult = ToMojoRegistration(*handle_ptr);
- callback.Run(BACKGROUND_SYNC_ERROR_NONE, std::move(mojoResult));
+ callback.Run(BackgroundSyncError::NONE, std::move(mojoResult));
}
void BackgroundSyncServiceImpl::ReleaseRegistration(
@@ -235,8 +235,7 @@ void BackgroundSyncServiceImpl::NotifyWhenFinished(
BackgroundSyncRegistrationHandle* registration =
active_handles_.Lookup(handle_id);
if (!registration) {
- callback.Run(BACKGROUND_SYNC_ERROR_NOT_ALLOWED,
- BACKGROUND_SYNC_STATE_FAILED);
+ callback.Run(BackgroundSyncError::NOT_ALLOWED, BackgroundSyncState::FAILED);
return;
}

Powered by Google App Engine
This is Rietveld 408576698