Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: components/web_view/web_view_apptest.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/public/cpp/web_view.cc ('k') | components/web_view/web_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/web_view_apptest.cc
diff --git a/components/web_view/web_view_apptest.cc b/components/web_view/web_view_apptest.cc
index eebd2d90338f1b1fea95c0295d5c16ea048894ac..1b144308c51b1b193c433e81cb63f6b9569f977f 100644
--- a/components/web_view/web_view_apptest.cc
+++ b/components/web_view/web_view_apptest.cc
@@ -187,35 +187,29 @@ TEST_F(WebViewTest, CanGoBackAndForward) {
// the stack.
EXPECT_EQ(GetTestFileURL(kTestOneFile).spec(), navigation_url());
EXPECT_EQ(kTestOneTitle, last_title());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_back_button_state());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_forward_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_back_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_forward_button_state());
ASSERT_NO_FATAL_FAILURE(NavigateTo(kTestTwoFile));
EXPECT_EQ(kTestTwoTitle, last_title());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_ENABLED, last_back_button_state());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_forward_button_state());
+ EXPECT_EQ(mojom::ButtonState::ENABLED, last_back_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_forward_button_state());
web_view()->GoBack();
StartNestedRunLoopUntil(LOADING_DONE);
EXPECT_EQ(GetTestFileURL(kTestOneFile).spec(), navigation_url());
EXPECT_EQ(kTestOneTitle, last_title());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_back_button_state());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_ENABLED,
- last_forward_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_back_button_state());
+ EXPECT_EQ(mojom::ButtonState::ENABLED, last_forward_button_state());
web_view()->GoForward();
StartNestedRunLoopUntil(LOADING_DONE);
EXPECT_EQ(GetTestFileURL(kTestTwoFile).spec(), navigation_url());
EXPECT_EQ(kTestTwoTitle, last_title());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_ENABLED, last_back_button_state());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_forward_button_state());
+ EXPECT_EQ(mojom::ButtonState::ENABLED, last_back_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_forward_button_state());
}
TEST_F(WebViewTest, NavigationClearsForward) {
@@ -229,19 +223,16 @@ TEST_F(WebViewTest, NavigationClearsForward) {
EXPECT_EQ(GetTestFileURL(kTestOneFile).spec(), navigation_url());
EXPECT_EQ(kTestOneTitle, last_title());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_back_button_state());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_ENABLED,
- last_forward_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_back_button_state());
+ EXPECT_EQ(mojom::ButtonState::ENABLED, last_forward_button_state());
// Now navigate to a third file. This should clear the forward stack.
ASSERT_NO_FATAL_FAILURE(NavigateTo(kTestThreeFile));
EXPECT_EQ(GetTestFileURL(kTestThreeFile).spec(), navigation_url());
EXPECT_EQ(kTestThreeTitle, last_title());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_ENABLED, last_back_button_state());
- EXPECT_EQ(mojom::ButtonState::BUTTON_STATE_DISABLED,
- last_forward_button_state());
+ EXPECT_EQ(mojom::ButtonState::ENABLED, last_back_button_state());
+ EXPECT_EQ(mojom::ButtonState::DISABLED, last_forward_button_state());
}
TEST_F(WebViewTest, Find) {
« no previous file with comments | « components/web_view/public/cpp/web_view.cc ('k') | components/web_view/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698