Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: components/mus/public/interfaces/input_event_matcher.mojom

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/public/interfaces/input_event_matcher.mojom
diff --git a/components/mus/public/interfaces/input_event_matcher.mojom b/components/mus/public/interfaces/input_event_matcher.mojom
index ec223e65ba313076b3288331e7933d91d52e1682..3e0929da2dd4fbc4d092afff750fa1be4501eba5 100644
--- a/components/mus/public/interfaces/input_event_matcher.mojom
+++ b/components/mus/public/interfaces/input_event_matcher.mojom
@@ -25,7 +25,9 @@ struct EventTypeMatcher {
};
struct EventFlagsMatcher {
- EventFlags flags;
+ // A bitfield of kEventFlag* and kMouseEventFlag* values in
+ // input_event_constants.mojom.
+ int32 flags;
};
// If a specific matcher is missing, then an Event will match this EventMatcher
@@ -33,12 +35,12 @@ struct EventFlagsMatcher {
// types will match this EventMatcher. Similarly, if |key_matcher| is missing,
// then all key-events will match.
// An example matcher to match the Ctrl+A accelerator would be:
-// - |type_matcher.type| = mojo::EVENT_TYPE_KEY_PRESSED
-// - |flags_matcher.flags| = mojo::EVENT_FLAGS_CONTROL_DOWN
-// - |key_matcher.keyboard_code| = mojo::KEYBOARD_CODE_A
+// - |type_matcher.type| = mus::mojom::EventType::KEY_PRESSED
+// - |flags_matcher.flags| = mus::mojom::kEventVlagControlDown
+// - |key_matcher.keyboard_code| = mus::mojom::KeyboardCode::A
//
// A matcher to match any key-press event would be:
-// - |type_matcher.type| = mojo::EVENT_TYPE_KEY_PRESSED
+// - |type_matcher.type| = mus::mojom::EventType::KEY_PRESSED
struct EventMatcher {
EventTypeMatcher? type_matcher;
EventFlagsMatcher? flags_matcher;
« no previous file with comments | « components/mus/public/interfaces/input_event_constants.mojom ('k') | components/mus/public/interfaces/input_events.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698