chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | chrome/browser/ui/views/frame/browser_frame_mus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

index b754f502327afbee09853a9473f318e12f1bb181..0eff178ef99bec7f0536e1f17807f97b3352a6b8 100644

--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

@@ -411,8 +411,7 @@ void ArcAppListPrefs::OnAppIcon(const mojo::String& package,

mojo::Array<uint8_t> icon_png_data) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

DCHECK_NE(0u, icon_png_data.size());

- DCHECK(scale_factor >= arc::SCALE_FACTOR_SCALE_FACTOR_100P &&

- scale_factor < arc::SCALE_FACTOR_NUM_SCALE_FACTORS);

+ DCHECK(arc::ScaleFactor_IsValidValue(scale_factor));

std::string app_id = GetAppId(package, activity);

if (!IsRegistered(app_id)) {

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | chrome/browser/ui/views/frame/browser_frame_mus.cc » ('j') | no next file with comments »