mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl ('K') | « mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

index 5321d29f1268ec8cf9afc24d62af8956fc91b4cb..f067e64f3674cb37afd29cf0b891ed9d27f9c82d 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

@@ -78,6 +78,8 @@ void SerializeUnion_({{union.name}}Ptr input, mojo::internal::Buffer* buf,

std::move(*input_acc.data()->{{field.name}}), {{field.name}});

{%- elif field.kind|is_associated_kind %}

// TODO(yzshen): add seralization logic for associated kinds.

+{% elif field.kind|is_enum_kind %}

+ result->data.f_{{field.name}} = static_cast<int32_t>(input_acc.data()->{{field.name}});

{% else %}

result->data.f_{{field.name}} = input_acc.data()->{{field.name}};

{%- endif %}