Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: mojo/public/cpp/bindings/tests/union_unittest.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/union_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/union_unittest.cc b/mojo/public/cpp/bindings/tests/union_unittest.cc
index bf8f6f896ae6acedf49c4959ff370785cd76ab8f..4028e4ed01ebd80bd2b1b4fb13b22e9b9a240910 100644
--- a/mojo/public/cpp/bindings/tests/union_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/union_unittest.cc
@@ -86,8 +86,8 @@ TEST(UnionTest, PlainOldDataGetterSetter) {
EXPECT_TRUE(pod->is_f_bool());
EXPECT_EQ(pod->which(), PodUnion::Tag::F_BOOL);
- pod->set_f_enum(AN_ENUM_SECOND);
- EXPECT_EQ(AN_ENUM_SECOND, pod->get_f_enum());
+ pod->set_f_enum(AnEnum::SECOND);
+ EXPECT_EQ(AnEnum::SECOND, pod->get_f_enum());
EXPECT_TRUE(pod->is_f_enum());
EXPECT_EQ(pod->which(), PodUnion::Tag::F_ENUM);
}
@@ -138,7 +138,7 @@ TEST(UnionTest, PodSerialization) {
TEST(UnionTest, EnumSerialization) {
PodUnionPtr pod1(PodUnion::New());
- pod1->set_f_enum(AN_ENUM_SECOND);
+ pod1->set_f_enum(AnEnum::SECOND);
size_t size = GetSerializedSize_(pod1, false);
EXPECT_EQ(16U, size);
@@ -150,7 +150,7 @@ TEST(UnionTest, EnumSerialization) {
PodUnionPtr pod2;
Deserialize_(data, &pod2, nullptr);
- EXPECT_EQ(AN_ENUM_SECOND, pod2->get_f_enum());
+ EXPECT_EQ(AnEnum::SECOND, pod2->get_f_enum());
EXPECT_TRUE(pod2->is_f_enum());
EXPECT_EQ(pod2->which(), PodUnion::Tag::F_ENUM);
}

Powered by Google App Engine
This is Rietveld 408576698