Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: mojo/public/cpp/bindings/tests/binding_unittest.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/binding_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/binding_unittest.cc b/mojo/public/cpp/bindings/tests/binding_unittest.cc
index 91002a4503cb21edd7a4be87067596d182fad31e..8cd97f88dab1a9f2001dd8a24672ab6b14473b86 100644
--- a/mojo/public/cpp/bindings/tests/binding_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/binding_unittest.cc
@@ -88,7 +88,7 @@ TEST_F(BindingTest, DestroyClosesMessagePipe) {
auto called_cb = [&called](int32_t result) { called = true; };
{
Binding<sample::Service> binding(&impl, std::move(request));
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
loop().RunUntilIdle();
EXPECT_TRUE(called);
@@ -101,7 +101,7 @@ TEST_F(BindingTest, DestroyClosesMessagePipe) {
// And calls should fail.
called = false;
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
loop().RunUntilIdle();
EXPECT_FALSE(called);
@@ -179,7 +179,7 @@ TEST_F(BindingTest, Unbind) {
bool called = false;
auto called_cb = [&called](int32_t result) { called = true; };
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
loop().RunUntilIdle();
EXPECT_TRUE(called);
@@ -188,7 +188,7 @@ TEST_F(BindingTest, Unbind) {
auto request = binding.Unbind();
EXPECT_FALSE(binding.is_bound());
// All calls should fail when not bound...
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
loop().RunUntilIdle();
EXPECT_FALSE(called);
@@ -197,7 +197,7 @@ TEST_F(BindingTest, Unbind) {
binding.Bind(std::move(request));
EXPECT_TRUE(binding.is_bound());
// ...and should succeed again when the rebound.
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
loop().RunUntilIdle();
EXPECT_TRUE(called);
@@ -211,7 +211,7 @@ class IntegerAccessorImpl : public sample::IntegerAccessor {
private:
// sample::IntegerAccessor implementation.
void GetInteger(const GetIntegerCallback& callback) override {
- callback.Run(1, sample::ENUM_VALUE);
+ callback.Run(1, sample::Enum::VALUE);
}
void SetInteger(int64_t data, sample::Enum type) override {}
@@ -233,7 +233,7 @@ TEST_F(BindingTest, PauseResume) {
ServiceImpl impl;
Binding<sample::Service> binding(&impl, std::move(request));
binding.PauseIncomingMethodCallProcessing();
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
EXPECT_FALSE(called);
loop().RunUntilIdle();
@@ -285,7 +285,7 @@ TEST_F(StrongBindingTest, DestroyClosesMessagePipe) {
auto called_cb = [&called](int32_t result) { called = true; };
{
StrongBinding<sample::Service> binding(&impl, std::move(request));
- ptr->Frobinate(nullptr, sample::Service::BAZ_OPTIONS_REGULAR, nullptr,
+ ptr->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
called_cb);
loop().RunUntilIdle();
EXPECT_TRUE(called);

Powered by Google App Engine
This is Rietveld 408576698