media/mojo/services/mojo_cdm_service.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/mojo_cdm_service.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/mojo/services/media_type_converters.cc ('K') | « media/mojo/services/media_type_converters.cc ('k') | media/mojo/services/mojo_decryptor.cc » ('j') | mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/services/mojo_cdm_service.cc

diff --git a/media/mojo/services/mojo_cdm_service.cc b/media/mojo/services/mojo_cdm_service.cc

index 31781b11e5fc5ec183dcd62c50f86ee04c0d3d5f..4df18ef09c287f2a6b23400efdd22b779490ca6f 100644

--- a/media/mojo/services/mojo_cdm_service.cc

+++ b/media/mojo/services/mojo_cdm_service.cc

@@ -196,7 +196,7 @@ void MojoCdmService::OnCdmCreated(const InitializeCallback& callback,

if (!cdm || !context_) {

cdm_promise_result->success = false;

cdm_promise_result->exception =

- interfaces::CDM_EXCEPTION_NOT_SUPPORTED_ERROR;

+ interfaces::CdmException::NOT_SUPPORTED_ERROR;

cdm_promise_result->system_code = 0;

cdm_promise_result->error_message = error_message;

callback.Run(std::move(cdm_promise_result), 0, nullptr);