media/mojo/interfaces/media_types.mojom - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/interfaces/media_types.mojom

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mojo/interfaces/media_types.mojom

diff --git a/media/mojo/interfaces/media_types.mojom b/media/mojo/interfaces/media_types.mojom

index befd80aa64872db5ef1f91e58a9b62ecdb17866f..3d9d719c88dca4117a36929e110a07a868f68d88 100644

--- a/media/mojo/interfaces/media_types.mojom

+++ b/media/mojo/interfaces/media_types.mojom

@@ -37,8 +37,6 @@ enum AudioCodec {

// See media/base/channel_layout.h for descriptions.

// Kept in sync with media::ChannelLayout via static_asserts.

-// TODO(tim): The bindings generators will always prepend the enum name, should

-// mojom therefore allow enum values starting with numbers?

enum ChannelLayout {

k_NONE = 0,

k_UNSUPPORTED = 1,

« mash/wm/property_util.h ('K') | « media/mojo/interfaces/decryptor.mojom ('k') | media/mojo/services/media_type_converters.cc » ('j') | media/mojo/services/media_type_converters.cc » ('J')