device/serial/serial_connection_factory.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_connection_factory.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/public/interfaces/input_events.mojom ('K') | « device/serial/serial_connection.cc ('k') | device/serial/serial_connection_unittest.cc » ('j') | mash/browser_driver/browser_driver_application_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/serial/serial_connection_factory.cc

diff --git a/device/serial/serial_connection_factory.cc b/device/serial/serial_connection_factory.cc

index d167a7878336b21b7dc5a69d775aaed827127916..8088a7e6b50de066686d0d0c9d7a6905341caa11 100644

--- a/device/serial/serial_connection_factory.cc

+++ b/device/serial/serial_connection_factory.cc

@@ -18,12 +18,12 @@ namespace {

void FillDefaultConnectionOptions(serial::ConnectionOptions* options) {

if (!options->bitrate)

options->bitrate = 9600;

- if (options->data_bits == serial::DATA_BITS_NONE)

- options->data_bits = serial::DATA_BITS_EIGHT;

- if (options->stop_bits == serial::STOP_BITS_NONE)

- options->stop_bits = serial::STOP_BITS_ONE;

- if (options->parity_bit == serial::PARITY_BIT_NONE)

- options->parity_bit = serial::PARITY_BIT_NO;

+ if (options->data_bits == serial::DataBits::NONE)

+ options->data_bits = serial::DataBits::EIGHT;

+ if (options->stop_bits == serial::StopBits::NONE)

+ options->stop_bits = serial::StopBits::ONE;

+ if (options->parity_bit == serial::ParityBit::NONE)

+ options->parity_bit = serial::ParityBit::NO;

if (!options->has_cts_flow_control) {

options->has_cts_flow_control = true;

options->cts_flow_control = false;