components/web_view/web_view_impl.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/web_view_impl.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/public/interfaces/input_events.mojom ('K') | « components/web_view/web_view_apptest.cc ('k') | content/browser/background_sync/background_sync_browsertest.cc » ('j') | mash/browser_driver/browser_driver_application_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/web_view_impl.cc

diff --git a/components/web_view/web_view_impl.cc b/components/web_view/web_view_impl.cc

index 43f01118cfb9fc0041611e86db258a533094cd28..2ae9cf58358031fe88e511a11f0ec548679c6fca 100644

--- a/components/web_view/web_view_impl.cc

+++ b/components/web_view/web_view_impl.cc

@@ -265,12 +265,11 @@ void WebViewImpl::OnNavigate(mojo::URLRequestPtr request) {

}

void WebViewImpl::OnDidNavigate() {

- client_->BackForwardChanged(navigation_controller_.CanGoBack()

- ? ButtonState::BUTTON_STATE_ENABLED

- : ButtonState::BUTTON_STATE_DISABLED,

- navigation_controller_.CanGoForward()

- ? ButtonState::BUTTON_STATE_ENABLED

- : ButtonState::BUTTON_STATE_DISABLED);

+ client_->BackForwardChanged(

+ navigation_controller_.CanGoBack() ? ButtonState::ENABLED

+ : ButtonState::DISABLED,

+ navigation_controller_.CanGoForward() ? ButtonState::ENABLED

+ : ButtonState::DISABLED);

}

////////////////////////////////////////////////////////////////////////////////