Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: components/mus/public/interfaces/input_event_constants.mojom

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/public/interfaces/input_event_constants.mojom
diff --git a/components/mus/public/interfaces/input_event_constants.mojom b/components/mus/public/interfaces/input_event_constants.mojom
index 900fc241d4beba91a5f95f6c88b99b63dabf47ea..1b4d18047871e74099c103990bd8c97b9b408ae0 100644
--- a/components/mus/public/interfaces/input_event_constants.mojom
+++ b/components/mus/public/interfaces/input_event_constants.mojom
@@ -17,33 +17,29 @@ enum EventType {
// This mirrors ui::EventFlags
// TODO(morrita): Use shift operator once it is available.
-enum EventFlags {
- NONE = 0,
- CAPS_LOCK_DOWN = 1,
- SHIFT_DOWN = 2,
- CONTROL_DOWN = 4,
- ALT_DOWN = 8,
- LEFT_MOUSE_BUTTON = 16,
- MIDDLE_MOUSE_BUTTON = 32,
- RIGHT_MOUSE_BUTTON = 64,
- COMMAND_DOWN = 128,
- EXTENDED = 256,
- IS_SYNTHESIZED = 512,
- ALTGR_DOWN = 1024,
- MOD3_DOWN = 2048,
- BACK_MOUSE_BUTTON = 4096,
- FORWARD_MOUSE_BUTTON = 8192,
- NUM_LOCK_DOWN = 16384,
- SCROLL_LOCK_DOWN = 32768,
-};
+const int32 kEventFlagNone = 0;
+const int32 kEventFlagCapsLockDown = 1;
+const int32 kEventFlagShiftDown = 2;
+const int32 kEventFlagControlDown = 4;
+const int32 kEventFlagAltDown = 8;
+const int32 kEventFlagLeftMouseButton = 16;
yzshen1 2016/01/07 19:24:52 Ah, this is because we don't support shift operato
Sam McNally 2016/01/08 05:12:51 Done.
+const int32 kEventFlagMiddleMouseButton = 32;
+const int32 kEventFlagRightMouseButton = 64;
+const int32 kEventFlagCommandDown = 128;
+const int32 kEventFlagExtended = 256;
+const int32 kEventFlagIsSynthesized = 512;
+const int32 kEventFlagAltgrDown = 1024;
+const int32 kEventFlagMod3Down = 2048;
+const int32 kEventFlagBackMouseButton = 4096;
+const int32 kEventFlagForwardMouseButton = 8192;
+const int32 kEventFlagNumLockDown = 16384;
+const int32 kEventFlagScrollLockDown = 32768;
-enum MouseEventFlags {
- IS_DOUBLE_CLICK = 65536,
- IS_TRIPLE_CLICK = 131072,
- IS_NON_CLIENT = 262144,
+const int32 kMouseEventFlagIsDoubleClick = 65536;
+const int32 kMouseEventFlagIsTripleClick = 131072;
+const int32 kMouseEventFlagIsNonClient = 262144;
- // TODO(erg): Move accessibility flags and maybe synthetic touch events here.
-};
+// TODO(erg): Move accessibility flags and maybe synthetic touch events here.
enum PointerKind {
MOUSE,

Powered by Google App Engine
This is Rietveld 408576698