components/mus/common/transient_window_utils.h - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/common/transient_window_utils.h

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/html_viewer/web_socket_handle_impl.cc ('k') | components/mus/public/cpp/event_matcher.h » ('j') | components/mus/public/interfaces/input_event_constants.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/common/transient_window_utils.h

diff --git a/components/mus/common/transient_window_utils.h b/components/mus/common/transient_window_utils.h

index 042e11dd493000f6bea5700e38135975344fc1b1..17eedc63a25a57807fa1d9b989a38300bde2d03b 100644

--- a/components/mus/common/transient_window_utils.h

+++ b/components/mus/common/transient_window_utils.h

@@ -78,7 +78,7 @@ bool AdjustStackingForTransientWindows(T** child,

FindCommonTransientAncestor(child, target);

// When stacking above skip to the topmost transient descendant of the target.

- if (*direction == mojom::ORDER_DIRECTION_ABOVE &&

+ if (*direction == mojom::OrderDirection::ABOVE &&

!HasTransientAncestor(*child, *target)) {

const std::vector<T*>& siblings((*child)->parent()->children());

size_t target_i =

@@ -116,7 +116,7 @@ void RestackTransientDescendants(T* window,

if ((*it) != window && HasTransientAncestor(*it, window)) {

T* old_stacking_target = *GetStackingTarget(*it);

*GetStackingTarget(*it) = window;

- Reorder(*it, window, mojom::ORDER_DIRECTION_ABOVE);

+ Reorder(*it, window, mojom::OrderDirection::ABOVE);

*GetStackingTarget(*it) = old_stacking_target;

}