components/html_viewer/document_resource_waiter.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/document_resource_waiter.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/html_viewer/blink_text_input_type_converters.cc ('k') | components/html_viewer/html_frame.cc » ('j') | components/mus/public/interfaces/input_event_constants.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/html_viewer/document_resource_waiter.cc

diff --git a/components/html_viewer/document_resource_waiter.cc b/components/html_viewer/document_resource_waiter.cc

index a9c3a0fc80731efa53cf1681b4da5d21b959e1ba..c7bbececa9684c99960457bacb1635da5fc2080a 100644

--- a/components/html_viewer/document_resource_waiter.cc

+++ b/components/html_viewer/document_resource_waiter.cc

@@ -24,7 +24,7 @@ DocumentResourceWaiter::DocumentResourceWaiter(GlobalState* global_state,

root_(nullptr),

change_id_(0u),

window_id_(0u),

- window_connect_type_(web_view::mojom::WINDOW_CONNECT_TYPE_USE_NEW),

+ window_connect_type_(web_view::mojom::WindowConnectType::USE_NEW),

frame_client_binding_(this),

is_ready_(false),

waiting_for_change_id_(false),

@@ -100,7 +100,7 @@ void DocumentResourceWaiter::UpdateIsReady() {

bool is_ready =

(!frame_data_.is_null() &&

((window_connect_type_ ==

- web_view::mojom::WINDOW_CONNECT_TYPE_USE_EXISTING) ||

+ web_view::mojom::WindowConnectType::USE_EXISTING) ||

(root_ && root_->viewport_metrics().device_pixel_ratio != 0.0f)));

if (is_ready) {

HTMLFrameTreeManager* frame_tree =