components/devtools_service/devtools_http_server.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_service/devtools_http_server.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/clipboard/clipboard_standalone_impl.cc ('k') | components/filesystem/directory_impl.cc » ('j') | components/mus/public/interfaces/input_event_constants.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_service/devtools_http_server.cc

diff --git a/components/devtools_service/devtools_http_server.cc b/components/devtools_service/devtools_http_server.cc

index 28dff655bb63f2a79c649bd5d4aa26f071a54d8b..e6836b81dd678ec026cf5ce8f8ab04554690ed73 100644

--- a/components/devtools_service/devtools_http_server.cc

+++ b/components/devtools_service/devtools_http_server.cc

@@ -251,7 +251,7 @@ class WebSocketRelayer : public DevToolsAgentHost::Delegate,

pending_send_count_--;

if (web_socket_ && buffer)

- web_socket_->Send(true, mojo::WebSocket::MESSAGE_TYPE_TEXT, num_bytes);

+ web_socket_->Send(true, mojo::WebSocket::MessageType::TEXT, num_bytes);

if (ShouldSelfDestruct())

delete this;

@@ -341,7 +341,7 @@ DevToolsHttpServer::DevToolsHttpServer(DevToolsService* service,

&network_service);

mojo::NetAddressPtr local_address(mojo::NetAddress::New());

- local_address->family = mojo::NET_ADDRESS_FAMILY_IPV4;

+ local_address->family = mojo::NetAddressFamily::IPV4;

local_address->ipv4 = mojo::NetAddressIPv4::New();

local_address->ipv4->port = remote_debugging_port;

local_address->ipv4->addr.resize(4);