Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 size_t GetSerializedSize_(const {{union.name}}Ptr& input, bool inlined) { 1 size_t GetSerializedSize_(const {{union.name}}Ptr& input, bool inlined) {
2 size_t size = 0U; 2 size_t size = 0U;
3 if (!inlined) { 3 if (!inlined) {
4 size += sizeof(internal::{{union.name}}_Data); 4 size += sizeof(internal::{{union.name}}_Data);
5 } 5 }
6 6
7 if (!input) 7 if (!input)
8 return size; 8 return size;
9 9
10 mojo::internal::UnionAccessor<{{union.name}}> input_acc(input.get()); 10 mojo::internal::UnionAccessor<{{union.name}}> input_acc(input.get());
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 result->data.f_{{field.name}} = 71 result->data.f_{{field.name}} =
72 input_acc.data()->{{field.name}}->release().value(); 72 input_acc.data()->{{field.name}}->release().value();
73 {% elif field.kind|is_interface_kind %} 73 {% elif field.kind|is_interface_kind %}
74 mojo::internal::Interface_Data* {{field.name}} = 74 mojo::internal::Interface_Data* {{field.name}} =
75 reinterpret_cast<mojo::internal::Interface_Data*>( 75 reinterpret_cast<mojo::internal::Interface_Data*>(
76 &result->data.f_{{field.name}}); 76 &result->data.f_{{field.name}});
77 mojo::internal::InterfacePointerToData( 77 mojo::internal::InterfacePointerToData(
78 std::move(*input_acc.data()->{{field.name}}), {{field.name}}); 78 std::move(*input_acc.data()->{{field.name}}), {{field.name}});
79 {%- elif field.kind|is_associated_kind %} 79 {%- elif field.kind|is_associated_kind %}
80 // TODO(yzshen): add seralization logic for associated kinds. 80 // TODO(yzshen): add seralization logic for associated kinds.
81 {% elif field.kind|is_enum_kind %}
82 result->data.f_{{field.name}} = static_cast<int32_t>(input_acc.data()->{ {field.name}});
81 {% else %} 83 {% else %}
82 result->data.f_{{field.name}} = input_acc.data()->{{field.name}}; 84 result->data.f_{{field.name}} = input_acc.data()->{{field.name}};
83 {%- endif %} 85 {%- endif %}
84 break; 86 break;
85 } 87 }
86 {%- endfor %} 88 {%- endfor %}
87 } 89 }
88 } else if (inlined) { 90 } else if (inlined) {
89 result->set_null(); 91 result->set_null();
90 } else { 92 } else {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 break; 131 break;
130 } 132 }
131 {%- endfor %} 133 {%- endfor %}
132 } 134 }
133 *output = std::move(result); 135 *output = std::move(result);
134 } else { 136 } else {
135 output->reset(); 137 output->reset();
136 } 138 }
137 return success; 139 return success;
138 } 140 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698