Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 content::PermissionManager* manager = profile->GetPermissionManager(); 256 content::PermissionManager* manager = profile->GetPermissionManager();
257 if (!manager) 257 if (!manager)
258 return; 258 return;
259 content::PermissionStatus embedding_permission_status = 259 content::PermissionStatus embedding_permission_status =
260 manager->GetPermissionStatus(permission, embedding_origin, 260 manager->GetPermissionStatus(permission, embedding_origin,
261 embedding_origin); 261 embedding_origin);
262 262
263 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet( 263 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
264 "Permissions.Requested.CrossOrigin_" + 264 "Permissions.Requested.CrossOrigin_" +
265 PermissionTypeToString(permission), 265 PermissionTypeToString(permission),
266 1, content::PERMISSION_STATUS_LAST, content::PERMISSION_STATUS_LAST + 1, 266 1, static_cast<int>(content::PermissionStatus::LAST),
267 static_cast<int>(content::PermissionStatus::LAST) + 1,
267 base::HistogramBase::kUmaTargetedHistogramFlag); 268 base::HistogramBase::kUmaTargetedHistogramFlag);
268 histogram->Add(embedding_permission_status); 269 histogram->Add(static_cast<int>(embedding_permission_status));
269 } else { 270 } else {
270 UMA_HISTOGRAM_ENUMERATION( 271 UMA_HISTOGRAM_ENUMERATION(
271 "Permissions.Requested.SameOrigin", 272 "Permissions.Requested.SameOrigin",
272 static_cast<base::HistogramBase::Sample>(permission), 273 static_cast<base::HistogramBase::Sample>(permission),
273 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 274 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
274 } 275 }
275 } 276 }
276 277
277 } // namespace 278 } // namespace
278 279
(...skipping 19 matching lines...) Expand all
298 299
299 void PermissionUmaUtil::PermissionDismissed(PermissionType permission, 300 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
300 const GURL& requesting_origin) { 301 const GURL& requesting_origin) {
301 RecordPermissionAction(permission, DISMISSED, requesting_origin); 302 RecordPermissionAction(permission, DISMISSED, requesting_origin);
302 } 303 }
303 304
304 void PermissionUmaUtil::PermissionIgnored(PermissionType permission, 305 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
305 const GURL& requesting_origin) { 306 const GURL& requesting_origin) {
306 RecordPermissionAction(permission, IGNORED, requesting_origin); 307 RecordPermissionAction(permission, IGNORED, requesting_origin);
307 } 308 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698