Support swarming dimensions in src-side JSON buildbot files.

Support swarming dimensions in src-side JSON buildbot files.

This will allow the GPU tests to be specified src-side.

BUG=542370
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298035

[Ken Russell (switch to Gerrit), 2015-12-15 23:36:44]

kbr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, sergiyb@chromium.org

[Ken Russell (switch to Gerrit), 2015-12-15 23:36:44]

Sergiy or Pawel: please review.

Marc-Antoine, Robbie, Luke: FYI.

[M-A Ruel, 2015-12-16 01:37:08]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-12-16 01:37:09]

that it super cool, thanks for doing this.

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:498: def
_get_gpu_suffix(self, dimensions):
Make it a @staticmethod

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:502: if gpu_vendor_id ==
'8086':
I'd prefer a small dict

vendor_ids = {
  '8086': 'Intel',
  ...
}

vendor_name = vendor_ids.get(vendor_id) or '(%s)' % vendor_id

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:1106: new_dimensions = {}
return [
  {str(k): str(v) for k, v in dimensions.iteritems()}
  for dimensions in dimension_sets
]

[Ken Russell (switch to Gerrit), 2015-12-16 01:50:47]

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:498: def
_get_gpu_suffix(self, dimensions):
On 2015/12/16 01:37:08, M-A Ruel wrote:
> Make it a @staticmethod

Done.

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:502: if gpu_vendor_id ==
'8086':
On 2015/12/16 01:37:08, M-A Ruel wrote:
> I'd prefer a small dict
> 
> vendor_ids = {
>   '8086': 'Intel',
>   ...
> }
> 
> vendor_name = vendor_ids.get(vendor_id) or '(%s)' % vendor_id

Done.

https://codereview.chromium.org/1527123002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:1106: new_dimensions = {}
On 2015/12/16 01:37:08, M-A Ruel wrote:
> return [
>   {str(k): str(v) for k, v in dimensions.iteritems()}
>   for dimensions in dimension_sets
> ]

Done.

[Sergiy Byelozyorov, 2015-12-16 14:44:54]

lgtm

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:505: '10de': 'NVIDIA',
nit: nVidia

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.py (right):

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.py:321: 'telemetry_gpu_unittests':
'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
nit: yupieeeeeeee... ;-)

[Paweł Hajdan Jr., 2015-12-16 14:48:35]

LGTM w/comment

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:518: else:
Can we check for Linux explicitly and say "unknown" otherwise?

[Ken Russell (switch to Gerrit), 2015-12-16 18:28:20]

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:505: '10de': 'NVIDIA',
On 2015/12/16 14:44:54, Sergiy Byelozyorov wrote:
> nit: nVidia

I'm leaving this as is to avoid changing tons of expectations unnecessarily.

https://codereview.chromium.org/1527123002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:518: else:
On 2015/12/16 14:48:35, Paweł Hajdan Jr. wrote:
> Can we check for Linux explicitly and say "unknown" otherwise?

Probably, but this is the way the old logic worked and I'd rather not have to
try to construct test expectations for an unknown platform right now.

[Ken Russell (switch to Gerrit), 2015-12-16 18:28:24]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2015-12-16 18:28:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527123002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527123002/40001

[commit-bot: I haz the power, 2015-12-16 18:32:29]

Description was changed from

==========
Support swarming dimensions in src-side JSON buildbot files.

This will allow the GPU tests to be specified src-side.

BUG=542370
==========

to

==========
Support swarming dimensions in src-side JSON buildbot files.

This will allow the GPU tests to be specified src-side.

BUG=542370

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298035
==========

[commit-bot: I haz the power, 2015-12-16 18:32:29]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298035