Source/WebKit/chromium/src/WebDOMCustomEvent.cpp - Issue 15271012: Clean up WebDOMEvent ownership of WebCore::Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebDOMCustomEvent.cpp

Issue 15271012: Clean up WebDOMEvent ownership of WebCore::Event. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Improve comments per review. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebKit/chromium/src/WebDOMCustomEvent.cpp

diff --git a/Source/WebKit/chromium/src/WebDOMCustomEvent.cpp b/Source/WebKit/chromium/src/WebDOMCustomEvent.cpp

index 0d5afd77cae8f3b4f10ed3eda44dfbe83f6c30a1..9b8da92d625436d62888e6cd77359b933ab4cd2b 100644

--- a/Source/WebKit/chromium/src/WebDOMCustomEvent.cpp

+++ b/Source/WebKit/chromium/src/WebDOMCustomEvent.cpp

@@ -42,7 +42,7 @@ namespace WebKit {

void WebDOMCustomEvent::initCustomEvent(const WebString& type, bool canBubble, bool cancelable, const WebSerializedScriptValue& webSerializedScriptValue)

{

- ASSERT(m_private);

+ ASSERT(m_private.get());

RefPtr<SerializedScriptValue> serializedScriptValue;

serializedScriptValue = webSerializedScriptValue;

unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable, serializedScriptValue.get());

« no previous file with comments | « Source/WebKit/chromium/public/WebSpeechInputResult.h ('k') | Source/WebKit/chromium/src/WebDOMEvent.cpp » ('j') | no next file with comments »