Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: net/quic/quic_session.h

Issue 1527013002: Clarify comments in QuicSession related to ownership of streams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@109748558
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session.h
diff --git a/net/quic/quic_session.h b/net/quic/quic_session.h
index 2e7de4d8d0fe4c35491f91d7eeda09a83b680ed1..200dd38e5fb9a0a2f2b12b78203a184b3780933c 100644
--- a/net/quic/quic_session.h
+++ b/net/quic/quic_session.h
@@ -225,7 +225,8 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
// Return the reserved crypto stream.
virtual QuicCryptoStream* GetCryptoStream() = 0;
- // Adds 'stream' to the active stream map.
+ // Adds |stream| to the dynamic stream map.
+ // Takes ownership of |stream|.
virtual void ActivateStream(ReliableQuicStream* stream);
// Returns the stream ID for a new outgoing stream, and increments the
@@ -331,7 +332,7 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
// that create these streams.
StreamMap static_stream_map_;
- // Map from StreamId to pointers to streams that are owned by the caller.
+ // Map from StreamId to pointers to streams. Owns the streams.
StreamMap dynamic_stream_map_;
// The ID to use for the next outgoing stream.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698