Replace using '_commentBeforeFunction' with visitXyzInScope().

Replace using '_commentBeforeFunction' with visitXyzInScope().

Otherwise it gets really ugly with using FunctionTypeAlias which does not have
a body, and getters not having a FormalParameterList, and with parameters for
function typed parameters...

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e5e1dc77bd7237ff7ddbeef9bc7467ebbc27728c

[Brian Wilkerson, 2015-12-17 14:54:21]

LGTM

https://codereview.chromium.org/1526973005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1526973005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:8626: if (node.documentationComment
!= null) {
These three lines occur often enough that it might be worth extracting a method:
  safelyVisitComment(node.documentationComment);

[scheglov, 2015-12-17 18:52:04]

https://codereview.chromium.org/1526973005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1526973005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:8626: if (node.documentationComment
!= null) {
On 2015/12/17 14:54:21, Brian Wilkerson wrote:
> These three lines occur often enough that it might be worth extracting a
method:
>   safelyVisitComment(node.documentationComment);

Done.

[scheglov, 2015-12-17 18:52:26]

Description was changed from

==========
Replace using '_commentBeforeFunction' with visitXyzInScope().

Otherwise it gets really ugly with using FunctionTypeAlias which does not have
a body, and getters not having a FormalParameterList, and with parameters for
function typed parameters...

R=brianwilkerson@google.com
BUG=
==========

to

==========
Replace using '_commentBeforeFunction' with visitXyzInScope().

Otherwise it gets really ugly with using FunctionTypeAlias which does not have
a body, and getters not having a FormalParameterList, and with parameters for
function typed parameters...

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e5e1dc77bd7237ff7ddbeef9bc7467ebbc27728c
==========

[scheglov, 2015-12-17 18:52:27]

Committed patchset #1 (id:1) manually as
e5e1dc77bd7237ff7ddbeef9bc7467ebbc27728c (presubmit successful).