Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1526953002: [proxies] Check for stack overflow when calling through to the target (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
neis, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Check for stack overflow in Proxy internal methods The proxy may be on its own target's or handler's prototype chain, leading to infinite recursion either when looking up the trap, or when calling through to the target. We can't eagerly prevent this from happening (e.g. at "foo.__proto__ = bar" calling time) because the presence of traps can change at any time. BUG=v8:1543, chromium:569882 LOG=n Committed: https://crrev.com/3d8b51e2485b0f104e7b5c60ce5764f1cd4a9f42 Cr-Commit-Position: refs/heads/master@{#32872}

Patch Set 1 #

Patch Set 2 : handlers too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -0 lines) Patch
M src/objects.cc View 1 12 chunks +24 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/proxies-prototype-handler-stackoverflow.js View 1 1 chunk +118 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/proxies-prototype-target-stackoverflow.js View 1 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jakob Kummerow
5 years ago (2015-12-15 14:22:43 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-15 16:31:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526953002/20001
5 years ago (2015-12-15 16:32:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 17:23:20 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 17:23:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d8b51e2485b0f104e7b5c60ce5764f1cd4a9f42
Cr-Commit-Position: refs/heads/master@{#32872}

Powered by Google App Engine
This is Rietveld 408576698