Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/password_manager/password_manager_delegate.h

Issue 152693003: Expose PasswordManagerDriver as a public interface to core Password code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_delegate.h
diff --git a/chrome/browser/password_manager/password_manager_delegate.h b/chrome/browser/password_manager/password_manager_delegate.h
index 0c3b8995c456023a0dce3bfdf8f09528d89c2fd3..8624d1fbe3510660f5eeb5d7c31a50642179b6ff 100644
--- a/chrome/browser/password_manager/password_manager_delegate.h
+++ b/chrome/browser/password_manager/password_manager_delegate.h
@@ -6,12 +6,9 @@
#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_DELEGATE_H_
class PasswordFormManager;
+class PasswordManagerDriver;
class Profile;
-namespace autofill {
-struct PasswordFormFillData;
-} // namespace autofill
-
// An abstraction of operations in the external environment (WebContents)
// that the PasswordManager depends on. This allows for more targeted
// unit testing.
@@ -20,12 +17,6 @@ class PasswordManagerDelegate {
PasswordManagerDelegate() {}
virtual ~PasswordManagerDelegate() {}
- // Fill forms matching |form_data| in |web_contents|. By default, goes
- // through the RenderViewHost to FillPasswordForm. Tests can override this
- // to sever the dependency on the entire rendering stack.
- virtual void FillPasswordForm(
- const autofill::PasswordFormFillData& form_data) = 0;
-
// A mechanism to show an infobar in the current tab at our request.
// The infobar may not show in some circumstances, such as when the one-click
// sign in infobar is or will be shown.
@@ -35,9 +26,9 @@ class PasswordManagerDelegate {
// Get the profile for which we are managing passwords.
virtual Profile* GetProfile() = 0;
- // If any SSL certificate errors were encountered as a result of the last
- // page load.
- virtual bool DidLastPageLoadEncounterSSLErrors() = 0;
+ // Returns the PasswordManagerDriver instance that is associated with this
Patrick Dubroy 2014/02/03 13:15:08 Nit: If you remove "that is" , you can bring this
blundell 2014/02/03 14:37:59 Done.
+ // instance.
+ virtual PasswordManagerDriver* GetDriver() = 0;
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerDelegate);

Powered by Google App Engine
This is Rietveld 408576698