Expose PasswordManagerDriver as a public interface to core Password code.

Expose PasswordManagerDriver as a public interface to core Password code.

This CL eliminates the forwarding that PasswordManagerDelegateImpl was
previously doing to ContentPasswordManagerDriver. Instead,
PasswordManagerDelegate has a new GetDriver() method that returns the
PasswordManagerDriver that the core PasswordManager code should use. Tests are
updated to reflect this change.

BUG=335096
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248592

[blundell, 2014-02-03 12:35:52]

Dependent on https://codereview.chromium.org/152643002/.

[Garrett Casto, 2014-02-03 13:13:01]

lgtm

[Patrick Dubroy, 2014-02-03 13:15:08]

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_form_manager_unittest.cc (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_form_manager_unittest.cc:24: class
PasswordManagerDriver;
Don't think you need this.

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_delegate.h (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_delegate.h:29: // Returns the
PasswordManagerDriver instance that is associated with this
Nit: If you remove "that is" , you can bring this down to one line ;-)

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_delegate_impl.cc (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_delegate_impl.cc:233: return
&driver_;
Any reason not to inline this in the header?

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_unittest.cc (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_unittest.cc:27: class
PasswordManagerDriver;
Not needed.

[blundell, 2014-02-03 14:37:59]

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_form_manager_unittest.cc (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_form_manager_unittest.cc:24: class
PasswordManagerDriver;
On 2014/02/03 13:15:08, Patrick Dubroy wrote:
> Don't think you need this.

Done.

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_delegate.h (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_delegate.h:29: // Returns the
PasswordManagerDriver instance that is associated with this
On 2014/02/03 13:15:08, Patrick Dubroy wrote:
> Nit: If you remove "that is" , you can bring this down to one line ;-)

Done.

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_delegate_impl.cc (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_delegate_impl.cc:233: return
&driver_;
On 2014/02/03 13:15:08, Patrick Dubroy wrote:
> Any reason not to inline this in the header?

Chromium style doesn't allow inlining virtual methods with non-empty bodies.

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_unittest.cc (right):

https://codereview.chromium.org/152693003/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_unittest.cc:27: class
PasswordManagerDriver;
On 2014/02/03 13:15:08, Patrick Dubroy wrote:
> Not needed.

Done.

[blundell, 2014-02-03 14:38:09]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-02-03 14:38:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/152693003/130001

[commit-bot: I haz the power, 2014-02-03 22:17:47]

Change committed as 248592

[commit-bot: I haz the power, 2014-02-03 22:17:47]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 22:17:53]

CQ bit was unchecked on CL. Ignoring.