Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: mojo/edk/system/data_pipe_producer_dispatcher.h

Issue 1526923006: [mojo] Implement data pipe using a shared buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/data_pipe_producer_dispatcher.h
diff --git a/mojo/edk/system/data_pipe_producer_dispatcher.h b/mojo/edk/system/data_pipe_producer_dispatcher.h
index d6920a3ce79ac44e8a776032f92fc7e64d28723e..70428853d3d4eebe6e95230f9cdfdaca73190c37 100644
--- a/mojo/edk/system/data_pipe_producer_dispatcher.h
+++ b/mojo/edk/system/data_pipe_producer_dispatcher.h
@@ -9,7 +9,9 @@
#include <stdint.h>
#include "base/memory/ref_counted.h"
+#include "mojo/edk/embedder/platform_shared_buffer.h"
#include "mojo/edk/system/awakable_list.h"
+#include "mojo/edk/system/data_pipe.h"
#include "mojo/edk/system/dispatcher.h"
#include "mojo/edk/system/raw_channel.h"
#include "mojo/edk/system/system_impl_export.h"
@@ -31,7 +33,13 @@ class MOJO_SYSTEM_IMPL_EXPORT DataPipeProducerDispatcher final
// Must be called before any other methods.
void Init(ScopedPlatformHandle message_pipe,
- char* serialized_write_buffer, size_t serialized_write_buffer_size);
+ char* serialized_write_buffer,
+ uint32_t serialized_write_buffer_size,
+ char* serialized_read_buffer,
+ uint32_t serialized_read_buffer_size,
+ ScopedPlatformHandle shared_buffer_handle,
+ uint32_t ring_buffer_start,
+ uint32_t ring_buffer_size);
// |Dispatcher| public methods:
Type GetType() const override;
@@ -44,7 +52,7 @@ class MOJO_SYSTEM_IMPL_EXPORT DataPipeProducerDispatcher final
PlatformHandleVector* platform_handles);
private:
- DataPipeProducerDispatcher(const MojoCreateDataPipeOptions& options);
+ explicit DataPipeProducerDispatcher(const MojoCreateDataPipeOptions& options);
~DataPipeProducerDispatcher() override;
void InitOnIO();
@@ -85,16 +93,10 @@ class MOJO_SYSTEM_IMPL_EXPORT DataPipeProducerDispatcher final
ScopedPlatformHandleVectorPtr platform_handles) override;
void OnError(Error error) override;
- bool InTwoPhaseWrite() const;
- bool WriteDataIntoMessages(const void* elements, uint32_t num_bytes);
+ bool ProcessCommand(const DataPipeCommandHeader& command,
+ ScopedPlatformHandleVectorPtr platform_handles);
- // See comment in MessagePipeDispatcher for this method.
- void SerializeInternal();
-
- MojoCreateDataPipeOptions options_;
-
- // Protected by |lock()|:
- RawChannel* channel_; // This will be null if closed.
+ scoped_refptr<DataPipe> data_pipe_;
AwakableList awakable_list_;
@@ -102,12 +104,11 @@ class MOJO_SYSTEM_IMPL_EXPORT DataPipeProducerDispatcher final
// avoid deadlocks with RawChannel calling us.
base::Lock started_transport_;
- bool error_;
+ bool calling_init_;
+ bool peer_closed_;
- bool serialized_;
- ScopedPlatformHandle serialized_platform_handle_;
- std::vector<char> serialized_write_buffer_;
- std::vector<char> two_phase_data_;
+ bool in_two_phase_write_;
+ uint32_t two_phase_max_bytes_write_;
MOJO_DISALLOW_COPY_AND_ASSIGN(DataPipeProducerDispatcher);
};

Powered by Google App Engine
This is Rietveld 408576698