Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1526923003: Specialize Sk2d for SSE2 (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Specialize Sk2d for SSE2 Given the autovectorization we've seen, I wouldn't expect big speedups from this, but it does give us a point of control over what's going on. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/fce612ac32a224d874acfce2b1ccf8db1a553307

Patch Set 1 #

Patch Set 2 : fix anyTrue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M src/core/SkNx.h View 1 chunk +8 lines, -3 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526923003/20001
5 years ago (2015-12-15 15:15:20 UTC) #3
mtklein_C
This low-boilerplate CL is brought to you by yesterday's refactor.
5 years ago (2015-12-15 15:15:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-15 15:34:16 UTC) #7
reed1
lgtm
5 years ago (2015-12-15 15:36:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526923003/20001
5 years ago (2015-12-15 15:38:21 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-15 15:38:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fce612ac32a224d874acfce2b1ccf8db1a553307

Powered by Google App Engine
This is Rietveld 408576698