Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1526913002: Revert of [WIP][turbofan] Instruction scheduler for Turbofan. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [WIP][turbofan] Instruction scheduler for Turbofan. (patchset #7 id:120001 of https://codereview.chromium.org/1375253002/ ) Reason for revert: Does not compile https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/6870/steps/compile/logs/stdio Original issue's description: > [turbofan] Instruction scheduler for Turbofan. > > Implement machine instruction scheduling after instruction selection. > > Currently only works for arm64. > > R=danno@chromium.org, bmeurer@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/e11bba3acd5188f0e12686b6fcf3e0ab22989216 > Cr-Commit-Position: refs/heads/master@{#32858} TBR=jarin@chromium.org,bmeurer@chromium.org,baptiste.afsa@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c6b122e8f996ebc34c94fe5b8221fa50c4561235 Cr-Commit-Position: refs/heads/master@{#32860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1325 lines) Patch
M BUILD.gn View 7 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +0 lines, -126 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/arm64/instruction-scheduler-arm64.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +0 lines, -133 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +33 lines, -37 lines 0 comments Download
D src/compiler/instruction-scheduler.h View 1 chunk +0 lines, -162 lines 0 comments Download
D src/compiler/instruction-scheduler.cc View 1 chunk +0 lines, -280 lines 0 comments Download
M src/compiler/instruction-selector.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +7 lines, -46 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/mips/instruction-scheduler-mips.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/mips64/instruction-scheduler-mips64.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +0 lines, -182 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/x87/instruction-scheduler-x87.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 9 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [WIP][turbofan] Instruction scheduler for Turbofan.
5 years ago (2015-12-15 11:26:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526913002/1
5 years ago (2015-12-15 11:27:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 11:27:34 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-15 11:27:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6b122e8f996ebc34c94fe5b8221fa50c4561235
Cr-Commit-Position: refs/heads/master@{#32860}

Powered by Google App Engine
This is Rietveld 408576698