Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: apps/app_shim/app_shim_host_mac_unittest.cc

Issue 15269003: Refactor extension handling code from AppShimHost into ExtensionAppShimHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add default handler to AppShimHandler. Fix test. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/app_shim/app_shim_host_mac_unittest.cc
diff --git a/apps/app_shim/app_shim_host_mac_unittest.cc b/apps/app_shim/app_shim_host_mac_unittest.cc
index 476b2ceb43748126aa5fe940e232f1c119215184..c94d5f32e6a23148661f85442b97edfae7fe57b1 100644
--- a/apps/app_shim/app_shim_host_mac_unittest.cc
+++ b/apps/app_shim/app_shim_host_mac_unittest.cc
@@ -42,7 +42,6 @@ class TestingAppShimHost : public AppShimHost {
protected:
virtual Profile* FetchProfileForDirectory(const std::string& profile_dir)
OVERRIDE;
- virtual bool LaunchApp(Profile* profile) OVERRIDE;
virtual bool Send(IPC::Message* message) OVERRIDE;
private:
@@ -77,10 +76,6 @@ Profile* TestingAppShimHost::FetchProfileForDirectory(
return fails_profile_ ? NULL : test_profile_;
}
-bool TestingAppShimHost::LaunchApp(Profile* profile) {
- return !fails_launch_;
-}
-
class AppShimHostTest : public testing::Test,
public apps::AppShimHandler {
public:
@@ -132,14 +127,6 @@ const char kTestProfileDir[] = "Default";
} // namespace
-TEST_F(AppShimHostTest, TestLaunchApp) {
- host()->ReceiveMessage(
- new AppShimHostMsg_LaunchApp(kTestProfileDir, kTestAppId));
- ASSERT_EQ(kTestAppId, host()->GetAppId());
- ASSERT_EQ(profile(), host()->GetProfile());
- ASSERT_TRUE(LaunchWasSuccessful());
-}
-
TEST_F(AppShimHostTest, TestLaunchAppWithHandler) {
apps::AppShimHandler::RegisterHandler(kTestAppId, this);
EXPECT_TRUE(host()->ReceiveMessage(

Powered by Google App Engine
This is Rietveld 408576698