Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Side by Side Diff: apps/app_shim/app_shim_handler_mac.h

Issue 15269003: Refactor extension handling code from AppShimHost into ExtensionAppShimHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Instantiate ExtensionAppShimHandler in AppShimHostManager. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | apps/app_shim/app_shim_handler_mac.cc » ('j') | apps/app_shim/app_shim_host_mac.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef APPS_APP_SHIM_APP_SHIM_HANDLER_MAC_H_ 5 #ifndef APPS_APP_SHIM_APP_SHIM_HANDLER_MAC_H_
6 #define APPS_APP_SHIM_APP_SHIM_HANDLER_MAC_H_ 6 #define APPS_APP_SHIM_APP_SHIM_HANDLER_MAC_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 class Profile;
11
10 namespace apps { 12 namespace apps {
11 13
12 // Registrar, and interface for services that can handle interactions with OSX 14 // Registrar, and interface for services that can handle interactions with OSX
13 // shim processes. 15 // shim processes.
14 class AppShimHandler { 16 class AppShimHandler {
15 public: 17 public:
16 class Host { 18 class Host {
17 public: 19 public:
18 // Invoked when the app is closed in the browser process. 20 // Invoked when the app is closed in the browser process.
19 virtual void OnAppClosed() = 0; 21 virtual void OnAppClosed() = 0;
20 22
23 // Allows the handler to determine which app this host corresponds to.
24 virtual Profile* GetProfile() const = 0;
25 virtual std::string GetAppId() const = 0;
26
21 protected: 27 protected:
22 virtual ~Host() {} 28 virtual ~Host() {}
23 }; 29 };
24 30
25 // Register a handler for an |app_mode_id|. 31 // Register a handler for an |app_mode_id|.
26 static void RegisterHandler(const std::string& app_mode_id, 32 static void RegisterHandler(const std::string& app_mode_id,
27 AppShimHandler* handler); 33 AppShimHandler* handler);
28 34
29 // Remove a handler for an |app_mode_id|. 35 // Remove a handler for an |app_mode_id|.
30 static void RemoveHandler(const std::string& app_mode_id); 36 static void RemoveHandler(const std::string& app_mode_id);
31 37
32 // Returns the handler registered for the given |app_mode_id|, or NULL if none 38 // Returns the handler registered for the given |app_mode_id|. If there is
33 // is registered. 39 // none registered, it returns the default handler or NULL if there is no
40 // default handler.
34 static AppShimHandler* GetForAppMode(const std::string& app_mode_id); 41 static AppShimHandler* GetForAppMode(const std::string& app_mode_id);
35 42
43 // Sets the default handler to return when there is no app-specific handler.
44 // Setting this to NULL removes the default handler.
45 static void SetDefaultHandler(AppShimHandler* handler);
46
36 // Invoked by the shim host when the shim process is launched. The handler 47 // Invoked by the shim host when the shim process is launched. The handler
37 // must return true if successful, or false to indicate back to the shim 48 // must return true if successful, or false to indicate back to the shim
38 // process that it should close. 49 // process that it should close.
39 virtual bool OnShimLaunch(Host* host) = 0; 50 virtual bool OnShimLaunch(Host* host) = 0;
40 51
41 // Invoked by the shim host when the connection to the shim process is closed. 52 // Invoked by the shim host when the connection to the shim process is closed.
42 virtual void OnShimClose(Host* host) = 0; 53 virtual void OnShimClose(Host* host) = 0;
43 54
44 // Invoked by the shim host when the shim process receives a focus event. 55 // Invoked by the shim host when the shim process receives a focus event.
45 virtual void OnShimFocus(Host* host) = 0; 56 virtual void OnShimFocus(Host* host) = 0;
46 57
47 protected: 58 protected:
48 AppShimHandler() {} 59 AppShimHandler() {}
49 virtual ~AppShimHandler() {} 60 virtual ~AppShimHandler() {}
50 }; 61 };
51 62
52 } // namespace apps 63 } // namespace apps
53 64
54 #endif // APPS_APP_SHIM_APP_SHIM_HANDLER_MAC_H_ 65 #endif // APPS_APP_SHIM_APP_SHIM_HANDLER_MAC_H_
OLDNEW
« no previous file with comments | « no previous file | apps/app_shim/app_shim_handler_mac.cc » ('j') | apps/app_shim/app_shim_host_mac.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698