Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1526843004: Update DEPS entry for tracing to point at correct location (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update DEPS entry for tracing to point at correct location While not really fitting our directory layout, the DEPS entry needs to be at exactly the same position as it is in chromium, otherwise either standalone or chromium build won't work :-/ BUG=none R=machenbach@chromium.org LOG=y Committed: https://crrev.com/4d1906d2a77dd79debb32d57c3c1ff0a1c99d113 Cr-Commit-Position: refs/heads/master@{#32896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M .gitignore View 2 chunks +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-16 09:47:00 UTC) #1
Michael Achenbach
lgtm
5 years ago (2015-12-16 12:13:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526843004/1
5 years ago (2015-12-16 12:15:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 12:16:36 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-16 12:17:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d1906d2a77dd79debb32d57c3c1ff0a1c99d113
Cr-Commit-Position: refs/heads/master@{#32896}

Powered by Google App Engine
This is Rietveld 408576698