Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: src/a64/lithium-a64.cc

Issue 152683005: A64: Fix addition of external value and int32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/lithium-a64.h ('k') | src/a64/lithium-codegen-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 838 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 if (instr->CheckFlag(HValue::kCanOverflow)) { 849 if (instr->CheckFlag(HValue::kCanOverflow)) {
850 result = AssignEnvironment(result); 850 result = AssignEnvironment(result);
851 } 851 }
852 return result; 852 return result;
853 } else if (instr->representation().IsExternal()) { 853 } else if (instr->representation().IsExternal()) {
854 ASSERT(instr->left()->representation().IsExternal()); 854 ASSERT(instr->left()->representation().IsExternal());
855 ASSERT(instr->right()->representation().IsInteger32()); 855 ASSERT(instr->right()->representation().IsInteger32());
856 ASSERT(!instr->CheckFlag(HValue::kCanOverflow)); 856 ASSERT(!instr->CheckFlag(HValue::kCanOverflow));
857 LOperand* left = UseRegisterAtStart(instr->left()); 857 LOperand* left = UseRegisterAtStart(instr->left());
858 LOperand* right = UseRegisterOrConstantAtStart(instr->right()); 858 LOperand* right = UseRegisterOrConstantAtStart(instr->right());
859 return DefineAsRegister(new(zone()) LAddI(left, right)); 859 return DefineAsRegister(new(zone()) LAddE(left, right));
860 } else if (instr->representation().IsDouble()) { 860 } else if (instr->representation().IsDouble()) {
861 return DoArithmeticD(Token::ADD, instr); 861 return DoArithmeticD(Token::ADD, instr);
862 } else { 862 } else {
863 ASSERT(instr->representation().IsTagged()); 863 ASSERT(instr->representation().IsTagged());
864 return DoArithmeticT(Token::ADD, instr); 864 return DoArithmeticT(Token::ADD, instr);
865 } 865 }
866 } 866 }
867 867
868 868
869 LInstruction* LChunkBuilder::DoAllocate(HAllocate* instr) { 869 LInstruction* LChunkBuilder::DoAllocate(HAllocate* instr) {
(...skipping 1571 matching lines...) Expand 10 before | Expand all | Expand 10 after
2441 2441
2442 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2442 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2443 LOperand* receiver = UseRegister(instr->receiver()); 2443 LOperand* receiver = UseRegister(instr->receiver());
2444 LOperand* function = UseRegister(instr->function()); 2444 LOperand* function = UseRegister(instr->function());
2445 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function); 2445 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function);
2446 return AssignEnvironment(DefineAsRegister(result)); 2446 return AssignEnvironment(DefineAsRegister(result));
2447 } 2447 }
2448 2448
2449 2449
2450 } } // namespace v8::internal 2450 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/a64/lithium-a64.h ('k') | src/a64/lithium-codegen-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698