Issue 152683004: Work on GN GYP host build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152683004: Work on GN GYP host build. (Closed)

Created:
6 years, 10 months ago by brettw

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Work on GN GYP host build. This stops doing the host build as a completely separate build and instead identifies the proper host toolchain inside of the "regular" build that we should use for host targets (if any). This should help unify GN's concept of host/target builds with GYPs a bit more. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250689

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : #

Patch Set 4 : fix tests compiling #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -191 lines)			Patch
M	build/config/BUILDCONFIG.gn	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	build/toolchain/mac/BUILD.gn	View		1 chunk	+81 lines, -62 lines	0 comments	Download
M	tools/gn/builder_unittest.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/command_gyp.cc	View		9 chunks	+68 lines, -123 lines	0 comments	Download
M	tools/gn/loader.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/gn/loader.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/152683004/300001

6 years, 10 months ago (2014-02-12 05:21:21 UTC) #4

Message was sent while issue was closed.

Change committed as 250689

Expand Messages | Collapse Messages