content/browser/android/download_controller_android_impl.h - Issue 152683003: Pass the filename obtained from content-disposition header for download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/download_controller_android_impl.h

Issue 152683003: Pass the filename obtained from content-disposition header for download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/android/download_controller_android_impl.cc » ('j') | content/browser/android/download_controller_android_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/download_controller_android_impl.h

diff --git a/content/browser/android/download_controller_android_impl.h b/content/browser/android/download_controller_android_impl.h

index db9b9cf99bba623f907b606c2e95fdb53976b5af..901c698d5389018355b18ff61204590820472874 100644

--- a/content/browser/android/download_controller_android_impl.h

+++ b/content/browser/android/download_controller_android_impl.h

@@ -65,6 +65,7 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid,

std::string user_agent;

std::string cookie;

std::string referer;

+ std::string filename;

boliu 2014/02/07 18:11:47 nothing uses this afaict?

Jinsuk Kim 2014/02/08 02:49:28 Ah right. Saw it wrong. Reverted.

WebContents* web_contents;

// Default copy constructor is used for passing this struct by value.

« no previous file with comments | « no previous file | content/browser/android/download_controller_android_impl.cc » ('j') | content/browser/android/download_controller_android_impl.cc » ('J')