Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152683002: Passwords: Remove references to BrowserThread from PasswordStore. (Closed)

Created:
6 years, 10 months ago by Patrick Dubroy
Modified:
6 years, 10 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, vabr (Chromium), blundell, stuartmorgan
Visibility:
Public.

Description

Passwords: Remove references to BrowserThread from PasswordStore. Inject a TaskRunner into the PasswordStore on creation, rather than directly referencing the UI thread. BUG=335136 R=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248729

Patch Set 1 #

Patch Set 2 : Moar. #

Patch Set 3 : Fix unit tests. #

Patch Set 4 : Fix more tests. #

Total comments: 9

Patch Set 5 : Fix another test. #

Patch Set 6 : Fix one last test. #

Patch Set 7 : A more modest fix for unit tests. #

Patch Set 8 : Address gcasto's comments. #

Patch Set 9 : Reformatting. #

Patch Set 10 : Remove DCHECKS that fail in sync tests. #

Patch Set 11 : Fix broken sync tests #

Patch Set 12 : Fix win tests. #

Patch Set 13 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -133 lines) Patch
M chrome/browser/password_manager/mock_password_store.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store.h View 1 2 3 4 5 6 7 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store.cc View 1 2 3 4 5 6 7 8 9 4 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.h View 1 2 3 4 5 6 7 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_default_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 2 3 4 5 6 7 8 2 chunks +27 lines, -11 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -4 lines 0 comments Download
chrome/browser/password_manager/password_store_mac_unittest.cc View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_unittest.cc View 1 2 3 4 5 6 2 chunks +5 lines, -47 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 1 2 3 4 5 6 7 1 chunk +11 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 2 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/test_password_store.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/test_password_store.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Patrick Dubroy
SVP jetez un coup d’oeil.
6 years, 10 months ago (2014-02-03 13:55:10 UTC) #1
Garrett Casto
https://codereview.chromium.org/152683002/diff/190001/chrome/browser/password_manager/password_store.cc File chrome/browser/password_manager/password_store.cc (right): https://codereview.chromium.org/152683002/diff/190001/chrome/browser/password_manager/password_store.cc#newcode70 chrome/browser/password_manager/password_store.cc:70: : main_task_runner_(main_task_runner), db_thread_runner_(db_thread_runner) Newline after main_task_runner_ and bring the ...
6 years, 10 months ago (2014-02-03 15:56:45 UTC) #2
Patrick Dubroy
https://codereview.chromium.org/152683002/diff/190001/chrome/browser/password_manager/password_store.cc File chrome/browser/password_manager/password_store.cc (right): https://codereview.chromium.org/152683002/diff/190001/chrome/browser/password_manager/password_store.cc#newcode70 chrome/browser/password_manager/password_store.cc:70: : main_task_runner_(main_task_runner), db_thread_runner_(db_thread_runner) On 2014/02/03 15:56:46, Garrett Casto wrote: ...
6 years, 10 months ago (2014-02-03 17:43:25 UTC) #3
Garrett Casto
lgtm
6 years, 10 months ago (2014-02-03 18:29:55 UTC) #4
Patrick Dubroy
The CQ bit was checked by dubroy@chromium.org
6 years, 10 months ago (2014-02-03 18:34:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/152683002/750001
6 years, 10 months ago (2014-02-03 18:35:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 19:19:46 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222358
6 years, 10 months ago (2014-02-03 19:19:46 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:19:49 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:19:52 UTC) #10
Patrick Dubroy
The CQ bit was checked by dubroy@chromium.org
6 years, 10 months ago (2014-02-04 09:47:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/152683002/990001
6 years, 10 months ago (2014-02-04 09:49:34 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 10:55:52 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120672
6 years, 10 months ago (2014-02-04 10:55:53 UTC) #14
Patrick Dubroy
The CQ bit was checked by dubroy@chromium.org
6 years, 10 months ago (2014-02-04 13:26:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/152683002/1290001
6 years, 10 months ago (2014-02-04 13:26:37 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 14:02:49 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223151
6 years, 10 months ago (2014-02-04 14:02:49 UTC) #18
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 14:02:51 UTC) #19
Patrick Dubroy
Committed patchset #13 manually as r248729 (presubmit successful).
6 years, 10 months ago (2014-02-04 16:23:49 UTC) #20
Patrick Dubroy
6 years, 10 months ago (2014-02-05 18:46:01 UTC) #21
Message was sent while issue was closed. 
+stuartmorgan FYI

Powered by Google App Engine
This is Rietveld 408576698