Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1526743004: [Android] Remove all references to pylib from telemetry. (Closed)

Created:
5 years ago by jbudorick
Modified:
5 years ago
CC:
chromium-reviews, rjkroege, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@devil-video-recorder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove all references to pylib from telemetry. BUG=476719 Committed: https://crrev.com/0a9fe7a42cf108bce46485fc9bcb6b9d81f08805 Cr-Commit-Position: refs/heads/master@{#365960}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : remove SetupPrebuiltTools patchers #

Messages

Total messages: 14 (7 generated)
jbudorick
5 years ago (2015-12-15 04:41:21 UTC) #2
aiolos (Not reviewing)
So much nicer. Lgtm. https://codereview.chromium.org/1526743004/diff/20001/tools/telemetry/telemetry/internal/backends/mandoline/android.py File tools/telemetry/telemetry/internal/backends/mandoline/android.py (right): https://codereview.chromium.org/1526743004/diff/20001/tools/telemetry/telemetry/internal/backends/mandoline/android.py#newcode144 tools/telemetry/telemetry/internal/backends/mandoline/android.py:144: return binary_manager.FetchPath('gdb', self.config.target_cpu, 'android') nit: ...
5 years ago (2015-12-15 07:52:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526743004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526743004/40001
5 years ago (2015-12-17 18:08:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/151369) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years ago (2015-12-17 19:06:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526743004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526743004/60001
5 years ago (2015-12-17 22:46:56 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-18 01:20:20 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-18 01:21:09 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0a9fe7a42cf108bce46485fc9bcb6b9d81f08805
Cr-Commit-Position: refs/heads/master@{#365960}

Powered by Google App Engine
This is Rietveld 408576698