Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1526643002:
Mark all APIs without callers in Blink as deprecated (Closed)
|
Created:
5 years ago by jochen (gone - plz use gerrit) Modified:
5 years ago Reviewers:
vogelheim CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMark all APIs without callers in Blink as deprecated
R=vogelheim@chromium.org
BUG=none
LOG=y
Committed: https://crrev.com/0018ca5ebb81ea3b6fd62bcf348710470c642ca2
Cr-Commit-Position: refs/heads/master@{#32980}
Patch Set 1 #Patch Set 2 : updates #Messages
Total messages: 17 (7 generated)
ptal I will probably wait until all methods of a given class are deprecated before starting to remove them, but it won't hurt to mark them as deprecated already now.
lgtm. v8_linux_chromium_gn_rel complains, but I'm guessing that's a Blink-side change that hasn't yet made it through the bots?
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/1526643002/#ps20001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526643002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526643002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526643002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Mark all APIs without callers in Blink as deprecated R=vogelheim@chromium.org BUG=none LOG=y ========== to ========== Mark all APIs without callers in Blink as deprecated R=vogelheim@chromium.org BUG=none LOG=y Committed: https://crrev.com/0018ca5ebb81ea3b6fd62bcf348710470c642ca2 Cr-Commit-Position: refs/heads/master@{#32980} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0018ca5ebb81ea3b6fd62bcf348710470c642ca2 Cr-Commit-Position: refs/heads/master@{#32980} |
