Issue 152663002: Remove shim classes etc. that were needed to move Android Loader

Issue 152663002: Remove shim classes etc. that were needed to move Android Loader (Closed)

Created:
6 years, 10 months ago by aberent

Modified:
6 years, 10 months ago

Reviewers:
darin (slow to review), Yaron, Jói

CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@moveLibraryLoader

Visibility:
Public.

More Reviews

Description

Remove shim classes etc. that were needed to move Android Loader Also those needed to move the Trace classes to base, and tidy up the other TODOs left over from these moves. Depends on: https://codereview.chromium.org/141223002 and https://chrome-internal-review.googlesource.com/#/c/153179 BUG=225101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250479

Patch Set 1 #

Patch Set 2 : Rebase to new version of other CLs. #

Patch Set 3 : Rebase to landed versions of predecessor CLs. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -417 lines)			Patch
M	base/android/java/src/org/chromium/base/library_loader/LoaderErrors.java	View		1 chunk	+4 lines, -9 lines	0 comments	Download
M	base/android/java/src/org/chromium/base/library_loader/ProcessInitException.java	View	1 2	2 chunks	+13 lines, -6 lines	0 comments	Download
D	base/android/java/src/org/chromium/content/common/ProcessInitException.java	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	build/android/findbugs_filter/findbugs_known_bugs.txt	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	build/java_apk.gypi	View		5 chunks	+3 lines, -7 lines	0 comments	Download
D	content/public/android/java/src/org/chromium/content/app/LibraryLoader.java	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	content/public/android/java/src/org/chromium/content/common/PerfTraceEvent.java	View		1 chunk	+0 lines, -148 lines	0 comments	Download
D	content/public/android/java/src/org/chromium/content/common/TraceEvent.java	View		1 chunk	+0 lines, -169 lines	0 comments	Download
M	content/public/common/result_codes_list.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aberent

yfriedman@chromium.org: Please review whole CL. joi@chromium.org: Please provide owner review of changes in content/public/results_code_list.h darin@chromium.org: ...

6 years, 10 months ago (2014-02-10 12:13:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/152663002/110001

6 years, 10 months ago (2014-02-11 17:49:17 UTC) #5

Message was sent while issue was closed.

Change committed as 250479

Expand Messages | Collapse Messages