Issue 1526623004: cps_ir: Add JS checks, use argument nullability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1526623004: cps_ir: Add JS checks, use argument nullability (Closed)

Created:
5 years ago by sra1

Modified:
5 years ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

cps_ir: Add JS checks, use argument nullability - Add JS checks for wrong number or captured placeholders. - Add list of nullability bits to allow generation of non-null placeholder expressions in place. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/620257ffc017aee3d247655f9fec31ecb0ab61ef

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -44 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	2 chunks	+16 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	3 chunks	+5 lines, -34 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View	2 chunks	+12 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

5 years ago (2015-12-15 18:38:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
620257ffc017aee3d247655f9fec31ecb0ab61ef (presubmit successful).