Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1526583002: Revert of [debugger] correctly find source position of implicit return statement. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] correctly find source position of implicit return statement. (patchset #1 id:1 of https://codereview.chromium.org/1521953003/ ) Reason for revert: Layout test failures: https://chromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Mac/builds/2732/steps/webkit_tests%20%28with%20patch%29/logs/stdio Original issue's description: > [debugger] correctly find source position of implicit return statement. > > The parser reads one character beyond EOF to have an additional source > position that the rewriter can use to insert the implicit return > statement at the end of a script. If we break at that return statement, > we need to be able to translate the source position to line and > column number. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 > Cr-Commit-Position: refs/heads/master@{#32825} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5a0233f6de5f9b188b82c5d79ae34e0eadd6bda0 Cr-Commit-Position: refs/heads/master@{#32829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M test/mjsunit/debug-sourceinfo.js View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
Created Revert of [debugger] correctly find source position of implicit return statement.
5 years ago (2015-12-14 10:25:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526583002/1
5 years ago (2015-12-14 10:25:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 10:25:47 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-14 10:26:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a0233f6de5f9b188b82c5d79ae34e0eadd6bda0
Cr-Commit-Position: refs/heads/master@{#32829}

Powered by Google App Engine
This is Rietveld 408576698