Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1526573002: [wasm] Fixed a wasm test on ia32. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fixed a wasm test on ia32. The test Run_Wasm_StoreMem_offset_oob contained an I64STORE instruction, which is not yet implemented on 32 bit platforms. I turned off those parts of the test on 32 bit platforms which contain I64 instructions. R=bradnelson@chromium.org Committed: https://crrev.com/973bc260c592057fa63f60658e22a56885703995 Cr-Commit-Position: refs/heads/master@{#32842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ahaas
5 years ago (2015-12-14 10:05:52 UTC) #1
bradn
lgtm
5 years ago (2015-12-14 11:57:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526573002/1
5 years ago (2015-12-14 11:57:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8909)
5 years ago (2015-12-14 11:59:41 UTC) #7
bradnelson
lgtm
5 years ago (2015-12-14 13:36:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526573002/1
5 years ago (2015-12-14 13:36:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8922)
5 years ago (2015-12-14 13:48:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526573002/1
5 years ago (2015-12-14 14:26:13 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 14:54:55 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-14 14:55:27 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/973bc260c592057fa63f60658e22a56885703995
Cr-Commit-Position: refs/heads/master@{#32842}

Powered by Google App Engine
This is Rietveld 408576698