Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 1526563005: Deprecate document.defaultCharset (to be removed in M50) (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate document.defaultCharset (to be removed in M50) Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/pWSb_tq13Kg/Dmk59Fb9AQAJ BUG=567738 Committed: https://crrev.com/42619d49918e60fde5017598fc83eb90d8d4b4f9 Cr-Commit-Position: refs/heads/master@{#366133}

Patch Set 1 #

Patch Set 2 : update test expectations #

Patch Set 3 : use willBeRemoved #

Patch Set 4 : update web-platform-tests/dom/historical-expected.txt #

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526563005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526563005/20001
5 years ago (2015-12-15 12:56:15 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/43539)
5 years ago (2015-12-15 13:08:41 UTC) #4
philipj_slow
PTAL. The build failure looks unrelated, will hopefully go away when sending to CQ.
5 years ago (2015-12-15 13:13:42 UTC) #6
jochen (gone - plz use gerrit)
lgtm but see my comment on the other CL
5 years ago (2015-12-16 08:56:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526563005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526563005/40001
5 years ago (2015-12-18 15:48:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/151930)
5 years ago (2015-12-18 17:03:39 UTC) #12
philipj_slow
update web-platform-tests/dom/historical-expected.txt
5 years ago (2015-12-18 17:48:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526563005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526563005/60001
5 years ago (2015-12-18 17:50:10 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-18 19:09:49 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-18 19:11:59 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/42619d49918e60fde5017598fc83eb90d8d4b4f9
Cr-Commit-Position: refs/heads/master@{#366133}

Powered by Google App Engine
This is Rietveld 408576698