Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: handler/crash_report_upload_thread.h

Issue 1526563003: Create WorkerThread, an abstraction to perform some work on an interval. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address coments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | handler/crash_report_upload_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/crash_report_upload_thread.h
diff --git a/handler/crash_report_upload_thread.h b/handler/crash_report_upload_thread.h
index 0372a83a3d4d1f2fae859ffcc52ae71d0f2f3eb6..f015ef945498fe7e714d2daa93adb43a01cac44e 100644
--- a/handler/crash_report_upload_thread.h
+++ b/handler/crash_report_upload_thread.h
@@ -21,14 +21,10 @@
#include "base/memory/scoped_ptr.h"
#include "client/crash_report_database.h"
-#include "util/synchronization/semaphore.h"
+#include "util/thread/worker_thread.h"
namespace crashpad {
-namespace internal {
-class CrashReportUploadHelperThread;
-} // namespace internal
-
//! \brief A thread that processes pending crash reports in a
//! CrashReportDatabase by uploading them or marking them as completed
//! without upload, as desired.
@@ -42,7 +38,7 @@ class CrashReportUploadHelperThread;
//! catches reports that are added without a ReportPending() signal being
//! caught. This may happen if crash reports are added to the database by other
//! processes.
-class CrashReportUploadThread {
+class CrashReportUploadThread : public WorkerThread::Delegate {
public:
//! \brief Constructs a new object.
//!
@@ -79,8 +75,6 @@ class CrashReportUploadThread {
void ReportPending();
private:
- friend internal::CrashReportUploadHelperThread;
-
//! \brief The result code from UploadReport().
enum class UploadResult {
//! \brief The crash report was uploaded successfully.
@@ -101,10 +95,6 @@ class CrashReportUploadThread {
kRetry,
};
- //! \brief Calls ProcessPendingReports() in response to ReportPending() having
- //! been called on any thread, as well as periodically on a timer.
- void ThreadMain();
-
//! \brief Obtains all pending reports from the database, and calls
//! ProcessPendingReport() to process each one.
void ProcessPendingReports();
@@ -138,11 +128,14 @@ class CrashReportUploadThread {
UploadResult UploadReport(const CrashReportDatabase::Report* report,
std::string* response_body);
+ // WorkerThread::Delegate:
+ //! \brief Calls ProcessPendingReports() in response to ReportPending() having
+ //! been called on any thread, as well as periodically on a timer.
+ void DoWork(const WorkerThread* thread) override;
+
std::string url_;
+ WorkerThread thread_;
CrashReportDatabase* database_; // weak
- Semaphore semaphore_; // TODO(mark): Use a condition variable instead?
- scoped_ptr<internal::CrashReportUploadHelperThread> thread_;
- bool running_;
};
} // namespace crashpad
« no previous file with comments | « no previous file | handler/crash_report_upload_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698