Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Side by Side Diff: test/mjsunit/es6/debug-blockscopes.js

Issue 1526553003: Revert of [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/debug-evaluate-shadowed-context.js ('k') | test/mjsunit/regress-3225.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --expose-debug-as debug --allow-natives-syntax 28 // Flags: --expose-debug-as debug --allow-natives-syntax
29 // Flags: --debug-eval-readonly-locals
30 // The functions used for testing backtraces. They are at the top to make the 29 // The functions used for testing backtraces. They are at the top to make the
31 // testing of source line/column easier. 30 // testing of source line/column easier.
32 31
33 "use strict"; 32 "use strict";
34 33
35 // Get the Debug object exposed from the debug context global object. 34 // Get the Debug object exposed from the debug context global object.
36 var Debug = debug.Debug; 35 var Debug = debug.Debug;
37 36
38 var test_name; 37 var test_name;
39 var listener_delegate; 38 var listener_delegate;
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 EndTest(); 518 EndTest();
520 519
521 520
522 // Block scopes shadowing 521 // Block scopes shadowing
523 BeginTest("Block scopes shadowing 1"); 522 BeginTest("Block scopes shadowing 1");
524 function shadowing_1() { 523 function shadowing_1() {
525 let i = 0; 524 let i = 0;
526 { 525 {
527 let i = 5; 526 let i = 5;
528 debugger; 527 debugger;
528 assertEqualsUnlessOptimized(27, i, shadowing_1);
529 } 529 }
530 assertEquals(0, i); 530 assertEquals(0, i);
531 debugger;
532 assertEqualsUnlessOptimized(27, i, shadowing_1);
531 } 533 }
532 534
533 listener_delegate = function (exec_state) { 535 listener_delegate = function (exec_state) {
534 assertEqualsUnlessOptimized(5, exec_state.frame(0).evaluate("i").value()); 536 exec_state.frame(0).evaluate("i = 27");
535 } 537 }
536 shadowing_1(); 538 shadowing_1();
537 EndTest(); 539 EndTest();
538 540
539 541
540 // Block scopes shadowing 542 // Block scopes shadowing
541 BeginTest("Block scopes shadowing 2"); 543 BeginTest("Block scopes shadowing 2");
542 function shadowing_2() { 544 function shadowing_2() {
543 let i = 0; 545 let i = 0;
544 { 546 {
545 let j = 5; 547 let j = 5;
546 debugger; 548 debugger;
549 assertEqualsUnlessOptimized(27, j, shadowing_2);
547 } 550 }
551 assertEqualsUnlessOptimized(0, i, shadowing_2);
548 } 552 }
549 553
550 listener_delegate = function (exec_state) { 554 listener_delegate = function (exec_state) {
551 assertEqualsUnlessOptimized(0, exec_state.frame(0).evaluate("i").value()); 555 exec_state.frame(0).evaluate("j = 27");
552 assertEqualsUnlessOptimized(5, exec_state.frame(0).evaluate("j").value());
553 } 556 }
554 shadowing_2(); 557 shadowing_2();
555 EndTest(); 558 EndTest();
OLDNEW
« no previous file with comments | « test/mjsunit/debug-evaluate-shadowed-context.js ('k') | test/mjsunit/regress-3225.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698