Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: pkg/analyzer_cli/test/driver_test.dart

Issue 1526533003: Disable temp-dir hosted tests pending fixes [TBR]. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/test/driver_test.dart
diff --git a/pkg/analyzer_cli/test/driver_test.dart b/pkg/analyzer_cli/test/driver_test.dart
index aa5551dde1f61045053731405a4c1ba4b549e4a4..1974cb2ceff6e3a83698ef57b701e6944fae4acc 100644
--- a/pkg/analyzer_cli/test/driver_test.dart
+++ b/pkg/analyzer_cli/test/driver_test.dart
@@ -256,67 +256,69 @@ linter:
});
});
- group('in temp directory', () {
- Directory savedCurrentDirectory;
- Directory tempDir;
- setUp(() {
- // Call base setUp.
- _setUp();
- savedCurrentDirectory = Directory.current;
- tempDir = Directory.systemTemp.createTempSync('analyzer_');
- });
- tearDown(() {
- Directory.current = savedCurrentDirectory;
- tempDir.deleteSync(recursive: true);
- // Call base tearDown.
- _tearDown();
- });
-
- test('packages folder', () {
- Directory.current = tempDir;
- new File(path.join(tempDir.path, 'test.dart')).writeAsStringSync('''
-import 'package:foo/bar.dart';
-main() {
- baz();
-}
- ''');
- Directory packagesDir =
- new Directory(path.join(tempDir.path, 'packages'));
- packagesDir.createSync();
- Directory fooDir = new Directory(path.join(packagesDir.path, 'foo'));
- fooDir.createSync();
- new File(path.join(fooDir.path, 'bar.dart')).writeAsStringSync('''
-void baz() {}
- ''');
- new Driver().start(['test.dart']);
- expect(exitCode, 0);
- });
-
- test('no package resolution', () {
- Directory.current = tempDir;
- new File(path.join(tempDir.path, 'test.dart')).writeAsStringSync('''
-import 'package:path/path.dart';
-main() {}
- ''');
- new Driver().start(['test.dart']);
- expect(exitCode, 3);
- String stdout = outSink.toString();
- expect(stdout, contains('[error] Target of URI does not exist'));
- expect(stdout, contains('1 error found.'));
- expect(errorSink.toString(), '');
- });
-
- test('bad package root', () {
- new Driver().start(['--package-root', 'does/not/exist', 'test.dart']);
- String stdout = outSink.toString();
- expect(exitCode, 3);
- expect(
- stdout,
- contains(
- 'Package root directory (does/not/exist) does not exist.'));
- });
- });
+//TODO(pq): fix to be bot-friendly (sdk#25258).
+// group('in temp directory', () {
+// Directory savedCurrentDirectory;
+// Directory tempDir;
+// setUp(() {
+// // Call base setUp.
+// _setUp();
+// savedCurrentDirectory = Directory.current;
+// tempDir = Directory.systemTemp.createTempSync('analyzer_');
+// });
+// tearDown(() {
+// Directory.current = savedCurrentDirectory;
+// tempDir.deleteSync(recursive: true);
+// // Call base tearDown.
+// _tearDown();
+// });
+//
+// test('packages folder', () {
+// Directory.current = tempDir;
+// new File(path.join(tempDir.path, 'test.dart')).writeAsStringSync('''
+//import 'package:foo/bar.dart';
+//main() {
+// baz();
+//}
+// ''');
+// Directory packagesDir =
+// new Directory(path.join(tempDir.path, 'packages'));
+// packagesDir.createSync();
+// Directory fooDir = new Directory(path.join(packagesDir.path, 'foo'));
+// fooDir.createSync();
+// new File(path.join(fooDir.path, 'bar.dart')).writeAsStringSync('''
+//void baz() {}
+// ''');
+// new Driver().start(['test.dart']);
+// expect(exitCode, 0);
+// });
+//
+// test('no package resolution', () {
+// Directory.current = tempDir;
+// new File(path.join(tempDir.path, 'test.dart')).writeAsStringSync('''
+//import 'package:path/path.dart';
+//main() {}
+// ''');
+// new Driver().start(['test.dart']);
+// expect(exitCode, 3);
+// String stdout = outSink.toString();
+// expect(stdout, contains('[error] Target of URI does not exist'));
+// expect(stdout, contains('1 error found.'));
+// expect(errorSink.toString(), '');
+// });
+//
+// test('bad package root', () {
+// new Driver().start(['--package-root', 'does/not/exist', 'test.dart']);
+// String stdout = outSink.toString();
+// expect(exitCode, 3);
+// expect(
+// stdout,
+// contains(
+// 'Package root directory (does/not/exist) does not exist.'));
+// });
+// });
});
+
group('Bootloader', () {
group('plugin processing', () {
test('bad format', () {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698